Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset Pixel Dead channels map Online GUI #45955

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Reset Pixel Dead channels map Online GUI #45955

merged 1 commit into from
Sep 11, 2024

Conversation

alaperto
Copy link
Contributor

@alaperto alaperto commented Sep 9, 2024 •
edited
Loading

PR description:

In the Online DQM GUI: reset Dead channels per ROC every 10 LS (as other maps) to improve Online DQM shifter understanding.

PR validation:

Data produced with cmsRun, i.e.:

cmsRun DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py dataset=/ZeroBias/Run2024G-v1/RAW runNumber=385311

Results checked in private Online QUI (to access need lxplus tunneling):

385311

####About backport:

This PR is intended for 2024 data taking. Corresponding Backports to:

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Sep 9, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45955/41713

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

A new Pull Request was created by @alaperto for master.

It involves the following packages:

  • DQM/SiPixelPhase1Summary (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

This was referenced Sep 9, 2024
Merged
Merged
@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61fc08/41444/summary.html
COMMIT: 28019ec
CMSSW: CMSSW_14_2_X_2024-09-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45955/41444/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 20dc5ff into cms-sw:master Sep 11, 2024
11 checks passed
This was referenced Sep 11, 2024
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed orp-approved tests-approved trk
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@alaperto @cmsbuild @antoniovagnerini @mandrenguyen